Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Verify access to Gitea deployment from InnerEye workspace #871

Closed
Tracked by #584
deniscep opened this issue Sep 16, 2021 · 4 comments
Closed
Tracked by #584

[Task] Verify access to Gitea deployment from InnerEye workspace #871

deniscep opened this issue Sep 16, 2021 · 4 comments

Comments

@deniscep
Copy link
Contributor

deniscep commented Sep 16, 2021

Story: #584

Verify that Compute Instance inside of InnerEye workspace can reach Gitea.

@deniscep deniscep changed the title [Task] Add Gitea deployment as part of InnerEye workspace [Task] Verify access to Gitea deployment from InnerEye workspace Sep 16, 2021
@msebragge msebragge self-assigned this Sep 24, 2021
@msebragge
Copy link
Contributor

msebragge commented Sep 29, 2021

@marrobi @deniscep

Gitea has a setting GITEA__server__ROOT_URL

Current value is https://gitea-cse-msr-dev.azurewebsites.net/gitea/

from internet https://cse-msr-dev.westeurope.cloudapp.azure.com/gitea works

from workspace https://gitea-cse-msr-dev.azurewebsites.net/ does not work since redirects go to
https://gitea-cse-msr-dev.azurewebsites.net/gitea/ (sign-in fails)

Changing the value to https://gitea-cse-msr-dev.azurewebsites.net/ fixes workspace access but breaks internet access.

It is possible to install gitea to a subfolder ie. https://gitea-cse-msr-dev.azurewebsites.net/gitea/ but that would require docker image changes go-gitea/gitea#3904

https://docs.gitea.io/en-us/reverse-proxies/#nginx-with-a-sub-path

Comments?

@deniscep
Copy link
Contributor Author

@marrobi is there a requirement for TRE Admin to be able to add packages? If so, then we need to look into a long-term fix for this (@Lybecker, @christoferlof), but for now, @msebragge I would change the GITEA__server__ROOT_URL to be the internal URL and add InnerEye packages to the gitea through the bundle setup, which is run by the processor, so on the internal network.

@marrobi
Copy link
Member

marrobi commented Sep 29, 2021

It is a requirement. We are already building a custom docker image so jus a case of replacing/modifying the nginx.conf in the dockerfile.

@deniscep
Copy link
Contributor Author

Cool, let's then add it to the list and get it done! Since this is prio (otherwise Gitea isn't usable from the WS), let's pull it right in. @msebragge I've added the task for this #955

@msebragge msebragge added the blocked Cannot progress at present label Sep 29, 2021
@msebragge msebragge removed the blocked Cannot progress at present label Oct 25, 2021
@msebragge msebragge removed their assignment Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants