-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open AI Workspace Service #4075
Open AI Workspace Service #4075
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 3669487. ♻️ This comment has been updated with latest results. |
Works great for me, once I sorted quota issues out. I had to manually set the version, as the default "auto update" selection didn;t work, seemed to be trying to use a version not available in the region. Blocked external: We should surface the API key somehow as a later issue as per #2401 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@harryy94 can you add the tags, not sure what was wrong before, but should support them: |
c34c069
to
3669487
Compare
Hi, thanks for your review :) For the above I realised I forgot this line
so I've added that in on the OpenAI instance. The other error I was getting was I accidentally tried to add tags on the deployment instead of the instance which doesn't support tags. |
/test-extended 3669487 Given base workspace and core changes doing full test. |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/10665019851 (with refid (in response to this comment from @marrobi) |
/destroy-test-env |
🤖 pr-bot 🤖
You can use the following commands: (in response to this comment from @marrobi) |
/test-destroy-env |
Destroying PR test environment (RG: rg-trecc34db55)... (run: https://github.com/microsoft/AzureTRE/actions/runs/10668007159) |
PR test environment destroy complete (RG: rg-trecc34db55) |
I seem to keep hitting this error: Error: Failed to download module
│
│ Could not download module "terraform_azurerm_environment_configuration" (main.tf:30) source code from
│ "git::https://github.com/microsoft/terraform-azurerm-environment-configuration.git?ref=0.6.0": error downloading
│ 'https://github.com/microsoft/terraform-azurerm-environment-configuration.git?ref=0.6.0': /usr/local/bin/git exited with 128: fatal: detected
│ dubious ownership in repository at
│ '/workspaces/AzureTRE/templates/workspace_services/openai/terraform/.terraform/modules/terraform_azurerm_environment_configuration'
│ To add an exception for this directory, call:
│
│ git config --global --add safe.directory
│ /workspaces/AzureTRE/templates/workspace_services/openai/terraform/.terraform/modules/terraform_azurerm_environment_configuration
│ Any ideas to add it permanently in? |
This in the dev container when building? I didn't get that. Weird. That module is used by other bundles too, so weird just seeing it now. |
Yeah I figured it was used elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addition of Open AI Workspace Service for #3810
This builds upon @marrobi 's original draft PR.
We are able to install an Open AI service and access it via the VM, and are still in progress of doing more tests, but welcome any feedback in the meantime!