Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Name, Role, Value - Property Pane_Ask a question (Bot Asks)]: Ensures all ARIA attributes have valid values for prompt edit field. #2063

Closed
ashish315 opened this issue Feb 23, 2020 · 3 comments · Fixed by #2281

Comments

@ashish315
Copy link

ashish315 commented Feb 23, 2020

User Experience:
This issue should be resolved for good coding practice as all ARIA attributes have valid values for the edit fields.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE.
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Navigate to already created dialog tree item and activate it. Such as- Greetings, Actions, EndDialog etc.
  5. Click on "+" and select 'Ask a question'. Then select any of the available options except Oauth login.
  6. Navigate to property pane appeared at right side of the screen and select 'Bot Asks'.
  7. Run Accessibility insight and observe the issue.

Actual:
Edit fields such as prompt, Max turn count, Default value, Allow interruption, Always prompt edit fields doesn't have valid ARIA attributes values.

Expected:
Every edit field must have valid aria attributes.

Note:

  1. Same issue found at "Property Pane_Ask a question (User Asks)".
  2. Same issue found at "Property Pane_Ask a question (Other)".
  3. Same issue observed at various property panes like Adaptive dialog and other property panes.

Observation:
This accessibility issue was found using Accessibility Insights for Web 2.14.1 (axe-core 3.3.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

MAS Impacted: MAS4.1.2

Attachment:
MAS4 1 1_Property Pane_Ask a question (User Input)
MAS4 1 1_Property Pane_Ask a question (Other)
MAS4 1 1_Property Pane_Ask a question (Bot Asks)

@beyackle
Copy link
Contributor

This appears to be also fixed by a PR I already have up. I'll tag that one here.

@ashish315
Copy link
Author

@cwhitten As checked on below environment the issue is still repro.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
Browser: Microsoft Edge Canary {Version 83.0.474.0 (Official build) canary (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

@ashish315
Copy link
Author

As checked, issue is fixed. So, HCL is closing the issue.

@ashish315 ashish315 removed the Fixed label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment