a11y: make SR read field descriptions on widgets #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the IconButton in WidgetLabel.tsx with a plain Icon bearing an aria-label.
corinagum
reviewed
Mar 16, 2020
| }} | ||
| aria-labelledby={`${id}-description`} | ||
| aria-label={ | ||
| // append a semicolon so the screen-reader pauses instead of making a confusing run-on |
corinagum
previously approved these changes
Mar 16, 2020
|
Just failing a unit test. I'll fix that and get it back up. |
…soft/BotFramework-Composer into beyackle/srWidgetLabelIcon
|
It looks like this PR fixes another issue too (#2063), so I'll link that here too. |
a-b-r-o-w-n
reviewed
Mar 17, 2020
| }} | ||
| aria-labelledby={`${id}-description`} | ||
| aria-label={ | ||
| // append a semicolon so the screen-reader pauses instead of making a confusing run-on |
|
Okay, verified that these aren't keyboard-navigable now. I'll fix that quickly and put up another version. |
Add a keyboard tab stop and adjust spacing - still not sure the SR experience is 100% great, but this at least makes it work.
|
Still not 100% happy with the SR experience here, but I think this addresses all the issues. |
a-b-r-o-w-n
reviewed
Mar 17, 2020
|
The original ticket specifically complained about the SR reading "button" when there isn't anything to click on, so we can't leave it a button. |
|
Maybe the Fabric team has some guidance on this? I'll send you a link to their channel. |
cwhitten
approved these changes
Mar 22, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* replace IconButton with Icon Replaces the IconButton in WidgetLabel.tsx with a plain Icon bearing an aria-label. * fix unit tests * Update WidgetLabel.tsx Add a keyboard tab stop and adjust spacing - still not sure the SR experience is 100% great, but this at least makes it work. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the IconButton in WidgetLabel.tsx with an ordinary Icon. The properties were copied over for the most part, except for some needed adjustment to the margins. One odd note here is that the screen reader's focus rectangle goes onto the editor field when reading the help text instead of the icon itself, but I think the behavior is basically correct as far as the SR experience goes.
Task Item
Closes #2115
Closes #2063
Screenshots