-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Runtime Settings page #2470
Comments
A few points
I like that, but i just want to clarify the implication of this, because by saying that, we are saying we don't assume the bot runtime live with the bot assets. If that's true, when we are selecting a bot to open, we can't select the runtime+declarative folder a whole bot, right, because there is not way to judge the whole folder is a bot or not. So for us, we either say I like a), because, supporting two modes (normal mode and ejected mode) sounds like we are looking for trouble.
And because our ejection is not a "eject and don't care anymore", so, if we can't guarantee ejecting perfectly, it would be risky to do that in place. I would rather to do it in a read-only approach to original bots, generating a new bot probably named (bota-ejected) and let user download it or choose to save it somewhere, probably only local. Then after ejecting to certain place, we go back to problem 1, how do we want user to open it. |
I have done a first pass of this, and opened a draft PR #2572 So far, all I've done is the basic UI for the settings. This UI is still in flux. |
Today:
|
have actual working file copy from plugin now. |
Let's make sure to include @garypretty 's efforts in this workstream around serializing some telemetry specific information to the settings file and the runtime template here: #2697 |
Is your feature request related to a problem? Please describe.
By default, new projects created in Composer will not contain the code needed to run the project. This will be provided automatically by the localPublish plugin that manages the local run/test cycle.
However, for bots that have a customized runtime or for existing projects that use Composer to edit declarative dialogs, developers need a way to manage that behavior.
Describe the solution you'd like
Composer needs a settings page where the location and behavior of the runtime can be configured.
Runtime behavior setting
This setting will control how the localPublish plugin handles the runtime for local testing.
If the custom runtime is enabled, the localPublish plugin will use these fields instead of using the "built in" runtime. See #2450 for details.
Eject runtime feature
As stated above, the default behavior is that new projects do not include the bot project code. However, we still need to provide this code to some developers at some point so they can extend or customize it.
The eject feature should:
The text was updated successfully, but these errors were encountered: