Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the runtime code we provide to users for configurability #2471

Closed
benbrown opened this issue Apr 1, 2020 · 9 comments · Fixed by #2923
Closed

Revise the runtime code we provide to users for configurability #2471

benbrown opened this issue Apr 1, 2020 · 9 comments · Fixed by #2923
Assignees
Labels
R9 Release 9 - May 15th, 2020

Comments

@benbrown
Copy link
Contributor

benbrown commented Apr 1, 2020

This is a draft ticket the requirements for this work are being gathered right now.

We need to make sure the runtime code we provide to users during the eject process (#2470) as well as when we deploy a bot in its unmodified form is well designed for configurability and extension.

Some major behaviors should be configuration driven:

We will need to make sure that, when deployed, the runtime will still be able to find the assets, and those assets will be in a logical location.

MORE TBD

@benbrown benbrown added Type: Enhancement Needs-triage A new issue that require triage labels Apr 1, 2020
@benbrown benbrown changed the title Revise the runtime code we provide to users for configurability DRAFT: Revise the runtime code we provide to users for configurability Apr 1, 2020
@benbrown benbrown self-assigned this Apr 1, 2020
@cwhitten cwhitten added R9 Release 9 - May 15th, 2020 and removed Needs-triage A new issue that require triage labels Apr 2, 2020
@boydc2014
Copy link
Contributor

@benbrown added two examples of middle-wares and @luhan2017 may have more options

@luhan2017
Copy link
Contributor

#2423 this PR is to enable a telemetry middleware in botproject.

@luhan2017
Copy link
Contributor

@benbrown, are you working on this right now? @zidaneymar in my team is working on some issues relates to middleware and some specific channel configurations. He probably can resolve most of the items in this list.

@benbrown
Copy link
Contributor Author

benbrown commented Apr 7, 2020

@luhan2017 I am not actively working on the code - I was just trying to gather requirements for the next revision of the code, particularly as it relates to the new "eject" feature described in #2470

@luhan2017
Copy link
Contributor

@luhan2017 I am not actively working on the code - I was just trying to gather requirements for the next revision of the code, particularly as it relates to the new "eject" feature described in #2470

OK, then I will ask @zidaneymar to work on this, and we can discuss more details if needed.

@InnoraG
Copy link

InnoraG commented Apr 8, 2020

This draft would bring great enhancement.
Please look for adapters as well if possible : https://github.com/microsoft/botbuilder-dotnet/tree/master/libraries/Adapters

@carlosscastro
Copy link
Member

Hello @luhan2017 ! I'm doing some refactors on bot project and integration with other potential deployment avenues such as azure Functions down the road. Do you have a branch where you folks are working?

@cwhitten cwhitten changed the title DRAFT: Revise the runtime code we provide to users for configurability Revise the runtime code we provide to users for configurability Apr 27, 2020
@cwhitten
Copy link
Member

addressed via #2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R9 Release 9 - May 15th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants