-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LG LSP in Composer #1504
Merged
Merged
feat: LG LSP in Composer #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFramework-Composer into shuwan/AddingLG_LSP
…tFramework-Composer into shuwan/AddingLG_LSP
ok I will take a look |
boydc2014
previously approved these changes
Nov 28, 2019
Looks good to me now, @cwhitten @a-b-r-o-w-n can you help take a look again? |
cwhitten
approved these changes
Nov 29, 2019
This was referenced Nov 29, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LG language server protocol (LSP) implementation for composer.
inline editor enhance
for inline editing, we no longer
hideArea
in editor, we put partial code on client, and the rest on language server, validation/completion/hover.. will be calculated from a combination file cross client and server.Task Item
closes #1485
closes #1635
closed #1628
closed #1482
Type of change
Please delete options that are not relevant.
Checklist
Screenshots