Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LG LSP in Composer #1504

Merged
merged 162 commits into from
Nov 29, 2019
Merged

feat: LG LSP in Composer #1504

merged 162 commits into from
Nov 29, 2019

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Nov 5, 2019

Description

LG language server protocol (LSP) implementation for composer.

inline editor enhance

for inline editing, we no longer hideArea in editor, we put partial code on client, and the rest on language server, validation/completion/hover.. will be calculated from a combination file cross client and server.

Task Item

closes #1485
closes #1635
closed #1628
closed #1482

Type of change

Please delete options that are not relevant.

  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

preview

preview

@zhixzhan
Copy link
Contributor Author

@zhixzhan Found one issue with the syntax highlighting,

in inline mode, the structured lg isn't highlighted
image

but in all up view, it works well
image

can you check with @cosmicshuai again?

ok I will take a look

boydc2014
boydc2014 previously approved these changes Nov 28, 2019
@boydc2014
Copy link
Contributor

Looks good to me now, @cwhitten @a-b-r-o-w-n can you help take a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants