style: Updated Array UI #1617
Merged
style: Updated Array UI #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
reviewed
Nov 28, 2019
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/ArrayItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/ArrayItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/ArrayItem.tsx
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/StringArray.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/StringArray.tsx
Outdated
Show resolved
Hide resolved
| onKeyDown={submitNewValidation} | ||
| schema={schema} | ||
| formContext={formContext} | ||
| rawErrors={[]} |
There was a problem hiding this comment.
Sure you want to send an empty array but not leaving it undefined? Then, use const EMPTY_ARRAY = []; outside of this function, so the reference never change and you don't need useMemo.
| schema={schema} | ||
| formContext={formContext} | ||
| rawErrors={[]} | ||
| styles={{ |
| </div> | ||
| <IconButton | ||
| disabled={true} | ||
| menuIconProps={{ iconName: 'MoreVertical' }} |
| disabled={true} | ||
| menuIconProps={{ iconName: 'MoreVertical' }} | ||
| ariaLabel={formatMessage('Item Actions')} | ||
| styles={{ |
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
tdurnford
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
tdurnford
commented
Dec 6, 2019
Composer/packages/extensions/obiformeditor/src/Form/fields/CustomObjectField.tsx
Outdated
Show resolved
Hide resolved
|
@tdurnford Scope the following screenshots: The RootField editable title has moved and looks off. Borders for fields with a value have largely disappeared. Fields with placeholder text have an opacity less than 1. Is this intentional? Single-item fields are not centered. |
cwhitten
approved these changes
Dec 10, 2019
Closed
Merged
This was referenced Dec 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated validation and choice options array field input UI.
Task Item
Closes #1510
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Choice Options
Validation Rules