Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix interruption sample #1624

Merged
merged 3 commits into from
Nov 21, 2019
Merged

fix: Fix interruption sample #1624

merged 3 commits into from
Nov 21, 2019

Conversation

luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented Nov 21, 2019 •
edited by a-b-r-o-w-n
Loading

  1. add a thredhold in GetStarted intent to avoid over trigger.
  2. fix malformed schema, extra comma
  3. fix value expression.
  4. fix turn.value -> this.value
  5. fix allowInterrutions: notRecognized->true

Task Item

closes #1627

@luhan2017
Fix interruption sample
7acfc73 
1. add a thredhold in GetStarted intent to avoid over trigger.
2. fix malformed schema, extra comma
3. fix value expression.
4. fix turn.value -> this.value
5. fix allowInterrutions: notRecognized->true
@github-actions
Copy link

Coverage Status

Coverage remained the same at 39.819% when pulling 7acfc73 on luhan/FixInteruptionSample into f0ebe56 on master.

@luhan2017
Copy link
Contributor Author

@a-b-r-o-w-n why the validation keep failing, I already attatched an issue in the body. any insights?
image

@a-b-r-o-w-n
Copy link
Contributor

@luhan2017 The PR description needs to use the github reference syntax (https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords). I will add some more details to the error output.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 29b4232 into master Nov 21, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the luhan/FixInteruptionSample branch November 21, 2019 15:56
@cwhitten cwhitten mentioned this pull request Nov 21, 2019
Closed
7 tasks
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwacsena vishwacsena vishwacsena approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhan2017 @a-b-r-o-w-n @vishwacsena