Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add directlinespeech support #1637

Merged
merged 1 commit into from
Nov 22, 2019
Merged

feat: add directlinespeech support #1637

merged 1 commit into from
Nov 22, 2019

Conversation

xieofxie
Copy link
Contributor

@xieofxie xieofxie commented Nov 22, 2019 •
edited
Loading

Description

Add directlinespeech support

Task Item

Close #1638

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

@github-actions
Copy link

Coverage Status

Coverage remained the same at 39.845% when pulling 8717f95 on hualxie/master into 2f96b52 on master.

@xieofxie xieofxie changed the title add directlinespeech support feat: add directlinespeech support Nov 22, 2019
@luhan2017 luhan2017 merged commit 7e84f05 into master Nov 22, 2019
@luhan2017 luhan2017 deleted the hualxie/master branch November 22, 2019 08:20
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xieofxie @luhan2017