Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: centralize lg parsing logic to 'shared' lib #1663

Merged
merged 46 commits into from
Dec 2, 2019
Merged

refactor: centralize lg parsing logic to 'shared' lib #1663

merged 46 commits into from
Dec 2, 2019

Commits on Nov 26, 2019

  1. implement basic lg apis

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7088206 View commit details
    Browse the repository at this point in the history

  2. expose them on 'shared' level

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    e975f16 View commit details
    Browse the repository at this point in the history

  3. UT + fix

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    531f317 View commit details
    Browse the repository at this point in the history

  4. add static parse() method to LgTemplateRef and LgMetaData

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    9e7c541 View commit details
    Browse the repository at this point in the history

  5. loose restriction on lg format

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b55f845 View commit details
    Browse the repository at this point in the history

  6. migrate: lgUtils

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    aae1d7c View commit details
    Browse the repository at this point in the history

  7. migrate: visual editor - hooks

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    13ce6b3 View commit details
    Browse the repository at this point in the history

  8. move 'extractLgTemplateRefs' inside 'shared' lib

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    1e6b5ea View commit details
    Browse the repository at this point in the history

  9. migrate: dialogIndexer

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    ee68dde View commit details
    Browse the repository at this point in the history

  10. migrate: LgEditorWidget

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    236b2e9 View commit details
    Browse the repository at this point in the history

  11. migrate: ObiEditor

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    6049ebc View commit details
    Browse the repository at this point in the history

  12. let shared lib built before others

    @yeze322
    yeze322 committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    bd7390b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. rename: patterns.ts -> lgPatterns.ts

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    4a1c52c View commit details
    Browse the repository at this point in the history

  2. fix ut: use the lg pattern in indexer file

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    c5cfb59 View commit details
    Browse the repository at this point in the history

  3. todo: mark up next pr's todo

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    e3d30e6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into lg/organize

    @yeze322
    yeze322 authored Nov 27, 2019
    Configuration menu
    Copy the full SHA
    3291366 View commit details
    Browse the repository at this point in the history

  5. comments: explain lg strings

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    456d08f View commit details
    Browse the repository at this point in the history

  6. enhance ut of parseLgTemplateRef

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    e3a9b69 View commit details
    Browse the repository at this point in the history

  7. do not export parsers

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    c2a69c7 View commit details
    Browse the repository at this point in the history

  8. clarify the concept of 'LgText'

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    1353a50 View commit details
    Browse the repository at this point in the history

  9. implement LgField with UT

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    f8b4d66 View commit details
    Browse the repository at this point in the history

  10. add two judement method in LgField

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    8254870 View commit details
    Browse the repository at this point in the history

  11. remove 'toLgText' method in LgMetaData

    @yeze322
    yeze322 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    490cc65 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. purify 'LgMetaData'

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    fb991d3 View commit details
    Browse the repository at this point in the history

  2. update LgMetaData usages

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    06a591d View commit details
    Browse the repository at this point in the history

  3. update stringTypes

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    b7daa72 View commit details
    Browse the repository at this point in the history

  4. remove LgFiled (over abstracted)

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9c31854 View commit details
    Browse the repository at this point in the history

  5. fix the usage of LgMetaData

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    02d4c15 View commit details
    Browse the repository at this point in the history

  6. rename param name to lgTemplateName

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    8eb4f40 View commit details
    Browse the repository at this point in the history

  7. refactor: apply LgTemplateRef to LgEditorWidget

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    67e091a View commit details
    Browse the repository at this point in the history

  8. set LgRef default parameters to '[]'

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    67c064f View commit details
    Browse the repository at this point in the history

  9. refactor: simplify 'getInitialTemplate'

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    31d6c99 View commit details
    Browse the repository at this point in the history

  10. enrich LgTempateRef test cases

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    48b910b View commit details
    Browse the repository at this point in the history

  11. folder structure

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    284e8ce View commit details
    Browse the repository at this point in the history

  12. take out string logic into string builders

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    216d413 View commit details
    Browse the repository at this point in the history

  13. clean: remove parseLgText since it's not referenced

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    d4738e6 View commit details
    Browse the repository at this point in the history

  14. extractLgTemplateNames => extractLgTemplateRefs

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    644ae1c View commit details
    Browse the repository at this point in the history

  15. fix a negative case in 'parseLgTemplateRef'

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    fc22977 View commit details
    Browse the repository at this point in the history

  16. merge extractLgTemplateRefs into 'parseLgTemplateRef'

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    cd0aa32 View commit details
    Browse the repository at this point in the history

  17. edit comments

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    6d1648b View commit details
    Browse the repository at this point in the history

  18. extract common code from parseLgTemplateRef

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    0bda795 View commit details
    Browse the repository at this point in the history

  19. clean

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    c7a289f View commit details
    Browse the repository at this point in the history

  20. add a single whitespace aftter '-' in LgEditorWIdget

    @yeze322
    yeze322 committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    17f0929 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Merge branch 'master' of https://github.com/Microsoft/BotFramework-Co… 

    …mposer into lg/organize
    @yeze322
    yeze322 committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    5aa6c5f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Merge branch 'master' into lg/organize

    @yeze322
    yeze322 committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    bd9930e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lg/organize

    @cwhitten
    cwhitten authored Dec 2, 2019
    Configuration menu
    Copy the full SHA
    7926a22 View commit details
    Browse the repository at this point in the history