-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deep linking for the notification page #1667
Conversation
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/fields/RecognizerField/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/code-editor.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/notifications/NotificationList.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
@lei9444 check out the following video: https://share.getcloudapp.com/Z4uwPKyg I think we're still over-reporting empty fields as errors. The video shows me supplying incorrect expression syntax, but 4 errors being reported for it instead of 1. The 3 additional errors are the empty field errors that shouldn't be errors at all. |
Hi, @cwhitten , It's a bug in checker function, I have fixed it now. I forget to clean the message and use the error message for all properties. |
Description
Task Item
refs #1582
Type of change
Please delete options that are not relevant.
Checklist
Screenshots