Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide more memory to Node in Docker #1670

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Nov 27, 2019

Description

Add ENV NODE_OPTIONS "--max-old-space-size=4096" to the Dockerfile to prevent Node from running out of memory inside the container

Task Item

refs #1669

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

@benbrown benbrown changed the title Provide more memory to Node in Docker fix: Provide more memory to Node in Docker Nov 27, 2019
@benbrown benbrown changed the base branch from stable to master November 27, 2019 18:25
@boydc2014
Copy link
Contributor

I did some investigation on this previously, and i try to set --max-old-space-size to 2048 because that's the default size of the allocated memory for docker-compose builder container. and i even don't have a way to change that.

Any size bigger than that, like 4096, will result in a OOF, because the container is asking more, but the system refuse to provide.

So @benbrown can you test with another machine? see if this will work?

@benbrown
Copy link
Contributor Author

benbrown commented Dec 2, 2019

@boydc2014 Are you suggesting that I need to test this on a machine with more RAM?

@github-actions
Copy link

github-actions bot commented Dec 2, 2019

Coverage Status

Coverage remained the same at 40.432% when pulling 88948c2 on benbrown/docker-memoruy into 9bfd927 on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 0048f8d into master Dec 2, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the benbrown/docker-memoruy branch December 2, 2019 18:09
@boydc2014
Copy link
Contributor

@boydc2014 Are you suggesting that I need to test this on a machine with more RAM?

I was suggesting testing with a machine with less RAM, :) . I think i figured out
image

@benbrown
Copy link
Contributor Author

benbrown commented Dec 6, 2019

I don't understand how computers work anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants