-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade lg parser and syntax #1676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
yeze322
as code owners
December 2, 2019 07:00
compulim
reviewed
Dec 3, 2019
Composer/packages/client/src/pages/language-generation/code-editor.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/table-view.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/table-view.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/table-view.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/table-view.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/utils/hooks.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-generation/src/utils.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-generation/src/utils.ts
Outdated
Show resolved
Hide resolved
zhixzhan
changed the title
refactor: upgrade to latest lg-parser
refactor: upgrade lg parser and syntax
Dec 3, 2019
I've checked those updates in '@bfc/shared -> lgUtils', no problem. |
cwhitten
approved these changes
Dec 4, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes:
"botbuilder-lg"
package-name instead of myget feed url in package dependency{Name, Parameters}
.. upper case to lower case[]
to@{}
[template ]
reference syntax will not be supported anymoresyntax updated:
Task Item
Closes #1676
Closes #1211
Closes #1542
Fixes #1680
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.