Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make update script cross platform compatible #1687

Merged
merged 2 commits into from
Dec 3, 2019
Merged

fix: make update script cross platform compatible #1687

merged 2 commits into from
Dec 3, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

refs #1674

tdurnford
tdurnford approved these changes Dec 2, 2019
View reviewed changes
Copy link
Collaborator

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tested on Windows

@cwhitten cwhitten merged commit cc6ed01 into microsoft:master Dec 3, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-update-script branch December 6, 2019 16:08
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@tdurnford tdurnford tdurnford approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @cwhitten @tdurnford