Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: one lg template error mess up others #1733

Merged
merged 2 commits into from
Dec 9, 2019
Merged

fix: one lg template error mess up others #1733

merged 2 commits into from
Dec 9, 2019

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 9, 2019 •
edited
Loading

Description

Greed try parse lgFile, fix one lg template error cause others blank field

If this is a bug fix, please describe the root cause and analysis of this problem.

Task Item

Fix #1732

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.
image

boydc2014
boydc2014 reviewed Dec 9, 2019
View reviewed changes
Composer/packages/lib/indexers/src/lgIndexer.ts
} catch (err) {
diagnostics.push(new Diagnostic(err.message, id, DiagnosticSeverity.Error));
}
try {
Copy link
Contributor

@boydc2014 boydc2014 Dec 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are fully aware that, there are some confusing and inconvenience how LG library provide features like validation and parsing, the core issue is parsing is not as tolerant as checker and CRUD functions.

Here is a thread in LG side, that we will consolidate the interface in LG side, and unify the experience, especially on error handling, microsoft/botbuilder-dotnet#3084.

Hopefully with this work, the code in Composer will be simplified significantly. Please take a look, and leave your opinions.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 2cf35f1 into microsoft:master Dec 9, 2019
@zhixzhan zhixzhan deleted the bugfix branch December 10, 2019 02:09
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhixzhan @a-b-r-o-w-n @boydc2014