Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show error message in form editor. #1737

Merged
merged 12 commits into from
Dec 10, 2019
Merged

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Dec 9, 2019

Description

Sync diagnostics info with notification page in form editor, includes lg, lu and expression dianostics.

Task Item

closes #1699
closes #1715

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

error

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback. I will do a functional test today.

@a-b-r-o-w-n
Copy link
Contributor

Couple more things:

  1. Need to conform to the Conventional PR style.
  2. e2e tests are failing.

@cwhitten cwhitten added the R7 Release 7 - December 10th, 2019 label Dec 9, 2019
a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Dec 9, 2019
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanlong9278 I think this is good to go. Can you test more scenarios today?

I did find a couple of things unrelated to this change: #1742 #1744

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.05%) to 40.308% when pulling c3fffd6 on julong/validation-message into 4180fed on master.

@alanlong9278
Copy link
Contributor Author

@alanlong9278 I think this is good to go. Can you test more scenarios today?

I did find a couple of things unrelated to this change: #1742 #1744

I have tested different scenarios, it runs well.

@alanlong9278
Copy link
Contributor Author

@a-b-r-o-w-n There are two items changed.

  1. Delete the value judgment logic because it will raise error when value is null in ifCondition's condition field.
// if (!value) {
  //   if (hiddenErrMessage) {
  //     onValidate && onValidate();
  //   }
  //   return '';
  // }

image

  1. Show error message + refer message in expression. The error message will be more detailed after @lei9444 's commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants