chore: upgrade vscode-eslint #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
zhixzhan
commented
Dec 18, 2019
| { "language": "typescript", "autoFix": true }, | ||
| { "language": "typescriptreact", "autoFix": true } | ||
| "typescript", | ||
| "typescriptreact", |
There was a problem hiding this comment.
vscode-eslint@2.* take "autoFix": true as default.
| "editor.formatOnSave": true, | ||
| "typescript.tsdk": "./Composer/node_modules/typescript/lib" | ||
| "typescript.tsdk": "./Composer/node_modules/typescript/lib", | ||
| "editor.codeActionsOnSave": { |
There was a problem hiding this comment.
imported by vscode-eslint@2.*, replacement of
"editor.formatOnSave": true,
"eslint.autoFixOnSave": true,
a-b-r-o-w-n
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade
vscode-eslintplugin from1.*to2.*, rewrite setting to latest recommended config.https://github.com/microsoft/vscode-eslint#release-notes
Breaking change:
Requires:
vscode@latest(>=1.41.0)
may not valid if your version can search & install latest vscode-eslint
vscode extension: vscode-eslint@latast(>=2.0.6)
if development environment haven't upgrade to latest, eslint auto format when save may not be work
Task Item
refs #1787
microsoft/vscode-eslint#840
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.