fix: show correct content in ChoiceInput (fixes #1930) #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
a-b-r-o-w-n
approved these changes
Feb 4, 2020
a-b-r-o-w-n
approved these changes
Feb 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1930
As reported in #1930 , there was too much white space in ChoiceInput.
After my investigation, the root cause should be the content of ChoiceInput was not shown correctly.
It should show a series of choices instead of a simple card.
This PR fixes this problem by updating ChoiceInput's uischema definition.
Schema diff looks like this:
Task Item
Closes #1930
Screenshots