Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync new schema in form editor #1996

Merged
merged 1 commit into from
Feb 18, 2020
Merged

chore: sync new schema in form editor #1996

merged 1 commit into from
Feb 18, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Feb 17, 2020 •
edited
Loading

Description

Replace includeActivity with activityProcessed for beginDialog in form editor depend on new schema.

  • Before
    image

  • After
    image

Task Item

fixed #1838

Screenshots

@github-actions
Copy link

Coverage Status

Coverage remained the same at 42.506% when pulling 889da42 on julong/newSchemaforForm into e387ade on master.

@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Feb 18, 2020
@alanlong9278 alanlong9278 merged commit 5180c91 into master Feb 18, 2020
@alanlong9278 alanlong9278 deleted the julong/newSchemaforForm branch February 18, 2020 07:43
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Feb 21, 2020
Merged
@cwhitten cwhitten mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanlong9278 @boydc2014 @luhan2017