Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: repaint ui for setProperties in visual editor #2017

Merged
merged 26 commits into from
Mar 3, 2020
Merged

feat: repaint ui for setProperties in visual editor #2017

merged 26 commits into from
Mar 3, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Feb 19, 2020 •
edited
Loading

Description

Repaint ui for setProperties with new design in visual editor.

What does this pr do?

  • Extract listOverview component.
    Like the pics show, the list in setProperties and multiInput is the same ui except the itemRender.
    So, we can extract listOverview and through sending renderFunciton to render different item list.
    image
    image

  • Define the elements as styledComponents
    Depends on new design, there are 4 types styled compoments. The element components can change the color by props.

  1. Span
    image

  2. SingleLineDiv
    image

  3. MultiLineDiv
    image

  4. BorderedDiv
    image

  5. LinkBtn
    image

  • Build setProperties, ChoiceInput with elements.
  • Use LinkBtn(elements) in dialogRef node.

What's next?

  • Add templateElement into element libs.

  • Refactor formCard to support new design.(Ze is doing)

  • Combine with the layout pr written by ze.

  • Rewrite the node ui with new design.

Task Item

fixes #1701

Screenshots

@alanlong9278 alanlong9278 changed the title feat: refactor node framework in visual editor feat: refine node framework in visual editor Feb 21, 2020
@alanlong9278 alanlong9278 marked this pull request as ready for review February 21, 2020 15:13
@github-actions
Copy link

Coverage Status

Coverage increased (+0.08%) to 42.585% when pulling cd3a822 on julong/nodeDesign into 6ff0da3 on master.

@alanlong9278 alanlong9278 changed the title feat: refine node framework in visual editor feat: New design for setProperties in visual editor Feb 24, 2020
@alanlong9278 alanlong9278 changed the title feat: New design for setProperties in visual editor feat: repaint ui for setProperties in visual editor Feb 24, 2020
@yeze322
Copy link
Contributor

yeze322 commented Feb 24, 2020

The styled component lib could help us standardize the design langauge we used in Visual Editor. It's a really good change.

We will migrate to the styled lib in future PRs.

@yeze322 yeze322 mentioned this pull request Feb 25, 2020
Closed
5 tasks
@yeze322 yeze322 self-requested a review February 26, 2020 06:51
yeze322
yeze322 suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@yeze322 yeze322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this PR has conflict with master:
image
image

We need to show full text instead of truncating and adding ellipsis.

yeze322
yeze322 suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@yeze322 yeze322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to reduce changes, improve code quality.

@yeze322 yeze322 merged commit aed7c65 into master Mar 3, 2020
@yeze322 yeze322 deleted the julong/nodeDesign branch March 3, 2020 04:36
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 9, 2020
Merged
@cwhitten cwhitten mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@yeze322 yeze322 yeze322 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanlong9278 @yeze322 @cwhitten @a-b-r-o-w-n