Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: style change for formCard in visual editor #2095

Merged
merged 1 commit into from
Feb 26, 2020
Merged

style: style change for formCard in visual editor #2095

merged 1 commit into from
Feb 26, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Feb 26, 2020 •
edited
Loading

Description

Style change for formCard in visual editor

Task Item

fixes #1701

Screenshots

@alanlong9278 alanlong9278 changed the base branch from stable to master February 26, 2020 07:38
@alanlong9278 alanlong9278 changed the title style: style change for formCard in visual editor styl: style change for formCard in visual editor Feb 26, 2020
@alanlong9278 alanlong9278 changed the title styl: style change for formCard in visual editor style: style change for formCard in visual editor Feb 26, 2020
@yeze322
Copy link
Contributor

yeze322 commented Feb 26, 2020 •
edited
Loading

This is a style issue reported by Brenda, introduced when I was working on 1701.
image
It's fixed as below
image

@github-actions
Copy link

Coverage Status

Coverage remained the same at 42.067% when pulling ce55c2d on julong/stylechange into 2a5a0fc on master.

@yeze322
Copy link
Contributor

yeze322 commented Feb 26, 2020

@cwhitten there is only 1 line style change, so I merge it directly in case Brenda needs to take screenshots

@yeze322 yeze322 merged commit 1f85367 into master Feb 26, 2020
@yeze322 yeze322 deleted the julong/stylechange branch February 26, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeze322 yeze322 yeze322 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanlong9278 @yeze322