-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deployment script, decouple debugging and deployment settings #2153
Conversation
Use appsettings.Deployment.json for local debug, use appsettings.Production.json for azure deployment.
@zidaneymar can you elaborate on the design of decoupling appsetttings.json into dev.json and prod.json? a few questions is
anyhow, let's get time to address those, and i put an onhold on this one in case accidentally merged. |
|
@@ -152,6 +152,8 @@ export class CSharpBotConnector implements IBotConnector { | |||
`bin/Debug/${envSettings.runtimeFrameworkVersion}/BotProject.dll`, | |||
`--urls`, | |||
this.endpoint, | |||
`--environment`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the protocol to add a new parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the protocol to add a new parameter
dotnet receive the env parameter to determine whether it's under development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this param will be sent to 'dotnet run' iteself, not a botproject level param.
https://stackoverflow.com/questions/50821504/asp-net-core-set-hosting-environment-in-build-process
…Framework-Composer into qika/deployupdate2
Description
fix #2007
Task Item
Screenshots