feat: enable composer to call a remote skill #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luhan2017 can we introduce the AdaptiveSkillDialog component schema in this PR as well? |
luhan2017
requested review from
a-b-r-o-w-n,
cwhitten and
yeze322
as code owners
yeze322
reviewed
Mar 13, 2020
Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
Outdated
Show resolved
Hide resolved
cwhitten
approved these changes
Mar 16, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I updated the bot project and enable composer to connect to a remote skill.
Note: A remote skill right now could not be a normal skill, It should have the ability to send and handle EndOfConversation type of Activity. Refer to https://github.com/microsoft/botbuilder-dotnet/tree/master/FunctionalTests/Skills/SimpleBotToBot/EchoSkillBot to create a remote skill.
How to connect to a remote skill:
Step1: configure settings. to call a remote skill, the bot must be registered with a MicrosoftAppID and MicrosoftPassword, and also SkillHostEndpoint, which is the skill endpoint of the current bot.
"MicrosoftAppPassword": "",
"MicrosoftAppId": "",
"SkillHostEndpoint": "http://localhost:3978/api/skills/" // http://localhost:3978 is the endpoint of the caller not callee.
Step2: add SkillDialog in the bot, for example:
{
"$kind": "Microsoft.SkillDialog",
"skillAppId": "3083d5b8-a3b6-4d50-82c7-af10aa96b20c", // the remote skill MicrosoftAppId
"skillEndpoint": "http://localhost:1205/api/messages", // the remote skill endpoint
"activity": "Hi"
}
Note: step2 can be added in Composer UX after the UX part is ready.
Step3: Click StartBot and Test in Emulator.
This PR is only to enable Composer to call a remote skill. It doesn't include creating a "remote skill" using composer.
Task Item
fixes #696
Screenshots