a11y: add ariaLabel props to EditableField and TextFields #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new prop to EditableField so we can wire through the accessibility information wherever it's needed.
beyackle
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
beyackle
changed the title
beyackle
changed the title
a-b-r-o-w-n
requested changes
Mar 12, 2020
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/ObjectArray.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/ArrayFieldTemplate/StringArray.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/fields/EditableField.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/obiformeditor/src/Form/widgets/TextWidget.tsx
Show resolved
Hide resolved
|
Only thing with making the placeholder same as the label is that sometimes the screenreader will read both. Should check for this before merging :) |
Better labels on array fields, and remove a spurious console log
…ft/BotFramework-Composer into beyackle/ariaLabelFields
a-b-r-o-w-n
approved these changes
Mar 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new prop to EditableField so we can wire through the accessibility information wherever it's needed.
Description
EditableField uses a TextField under the hood, which already supports "ariaLabel" as a prop, so we just need to wire that through directly as a new prop and then set sensible labels on all the EditableFields.
Task Item
Closes #2140