a11y: add SR labels to Bot Responses "used" column #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some aria labels to both the checkmark icon and the empty space inside the table of Bot Responses.
beyackle
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
zhixzhan
approved these changes
Mar 13, 2020
cwhitten
approved these changes
Mar 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds proper screen-reader labels to the "Been used" column in Bot Responses. Now, instead of "read-only, button" and "read-only", the cells are read as "used" and "unused".
Task Item
Closes #2049