Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Use h1 tag for trigger in visual editor #2271

Merged
merged 4 commits into from
Mar 18, 2020
Merged

a11y: Use h1 tag for trigger in visual editor #2271

merged 4 commits into from
Mar 18, 2020

Conversation

alanlong9278
Copy link
Contributor

Description

Use h1 tag for trigger in visual editor

Task Item

fixes #2028

Screenshots

image

@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.975% when pulling bc229d0 on julong/headerTagInVisual into ad6903d on master.

corinagum
corinagum approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwhitten cwhitten merged commit c08dc7a into master Mar 18, 2020
@cwhitten cwhitten deleted the julong/headerTagInVisual branch March 18, 2020 16:00
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanlong9278 @cwhitten @corinagum