a11y: #2109 Improve UX and accessibility of deploy dialogs #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
cwhitten
approved these changes
Mar 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables/disables modal 'Next' button based on validity of required data-fields' values
Validates input on blur
Auto-focuses on first input in dialog
Maintains all errors within
formData(doesn't replace the entire errors object when a new error comes in)On form submit, if any data is invalid, it will focus on that input
Add
aria-requiredin order to improve AT UXAdd self to CODEOWNERS (for future a11y PRs)
Task Item
Closes #2109
Screenshots