a11y: make dialog name required #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
approved these changes
Mar 18, 2020
Merged
|
@boydc2014 This should also include |
|
Adding an aria prop to a Fabric component is something the Fabric team should know about (and would help anyone else adding the required prop to their TextFields); I'm just taking advantage of the API they give us. |
|
🤦♀️ Checked the docs properly after your message. Sorry about that. I'll go back and fix my own code later in my next PR. |
|
Looks like they don't plan on implementing it. Thanks for the correction, @beyackle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One-line fix to make it clear that this field is mandatory
Task Item
Closes #2073
Screenshots