feat: Adding language parameter #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: 03-18-2020
I have added language parameter for generating the luconfig.json file to allow generation in another language. For example is-is. Also I have added property control to make it 'es-us' by default
MunozVictor
changed the title
|
@zidaneymar can you help review this one? |
zidaneymar
reviewed
Mar 20, 2020
There was a problem hiding this comment.
@MunozVictor , hi, thanks for your commit, this pr should be merged into master rather than stable, other things are good.
|
Sorry , I changed to master branch but I don´t know how can I pass the Validation PR style without any issue relation |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
I have added language parameter for generating the luconfig.json file to allow generation in another language. For example is-is. Also I have added property control to make it 'es-us' by default Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added language parameter for generating the luconfig.json file to allow generation in another language. For example es-es.
Also I have added property control to make it 'es-us' by default
Task Item
Screenshots