Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set luis recognizer type for dialog in formEditor #2347

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

alanlong9278
Copy link
Contributor

Description

set luis recognizer type for dialog recognizer property in formEditor.

There is the code to set luis recognizer type in current master branch.

 if (selectedFile) {
  onChange(currentDialog.luFile);
}

image

But currentDialog.luFile is '', it will cause the recognizer is '', and can not create recognizered intent, So I revert the code to

if (selectedFile) {
  onChange(`${currentDialogId}.lu`);
}

Task Item

Screenshots

@github-actions
Copy link

Coverage Status

Coverage remained the same at 39.591% when pulling e6967b0 on julong/recognizerBugfix into 8d594d5 on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 52452d2 into master Mar 24, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the julong/recognizerBugfix branch March 24, 2020 19:06
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants