Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate editor.schema in favor of pure ui schema #2389

Merged
merged 4 commits into from
Mar 27, 2020
Merged

fix: deprecate editor.schema in favor of pure ui schema #2389

merged 4 commits into from
Mar 27, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Mar 26, 2020 •
edited
Loading

Description

Removes usage of editor.schema. Moves those labels into the ui schema. At some point in the future, a bot project will provide a ui schema as well.

Task Item

fixes #2372

@cwhitten cwhitten merged commit 6f35dca into microsoft:master Mar 27, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix/remove-editor-schema branch March 27, 2020 15:19
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n @cwhitten
fix: deprecate editor.schema in favor of pure ui schema (microsoft#2389)
7ee657d 
* remove editor schema, move labels and subtitles to uiSchema

* update snapshot

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-b-r-o-w-n @cwhitten