feat: create lg template when schema provides a default value #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
boydc2014,
corinagum and
cwhitten
as code owners
cwhitten
approved these changes
Apr 2, 2020
zhixzhan
reviewed
Apr 3, 2020
| lgFile.templates && | ||
| lgFile.templates.find(template => { | ||
| const hasTemplate = useMemo(() => lgFile?.templates.find(t => t.name === lgName), []); | ||
| const template = (hasTemplate && |
There was a problem hiding this comment.
Here seems no need to find again, if hasTemplate is not a boolean value. it's equal to
const template = hasTemplate || {
name: lgName,
parameters: [],
body: getInitialTemplate(name, value),
};
a-b-r-o-w-n
added a commit
to a-b-r-o-w-n/BotFramework-Composer
that referenced
this pull request
Apr 3, 2020
…microsoft#2487)" This reverts commit df97a7e.
a-b-r-o-w-n
added a commit
that referenced
this pull request
Apr 3, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#2487) * fix cardNoMatchResponse property name * create lg template when field has a default value
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…microsoft#2487)" (microsoft#2500) This reverts commit 80814a1. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the user had to interact with the editor in order to get the template saved.
Note: There is an issue right now with the lg api where if there are multiple parallel writes, the last write wins. So only the last lg field on the form will be created. There is an issue tracking this: #2247
Task Item
closes #2406