a11y: add sorting ability to Open dialog #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
corinagum
reviewed
Apr 13, 2020
Composer/packages/client/src/CreationFlow/LocationBrowser/FileSelector.tsx
Show resolved
Hide resolved
corinagum
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
@beyackle LGTM!
I'm still a little confused about the icon (where I left a comment). Seems to me like the files should still be in the repo. Before merge, could you take a look? If I'm wrong, this is good to merge. comment addressed.
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add sorting ability to Open dialog * linter stuff Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds in sorting behavior to our File Selection box in the Open dialog.
Task Item
refs #2067
Screenshots