-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add down sampling before luis publish #2629
Conversation
Composer/packages/server/src/models/bot/sampler/ReservoirSampler.ts
Outdated
Show resolved
Hide resolved
Composer/packages/server/src/models/bot/sampler/BootstrapSampler.ts
Outdated
Show resolved
Hide resolved
In terms of putting it into samples, we should give this a meaningful name downsampling: { |
Hi @boydc2014 I have add the config to client setting now. user can update it in setting page |
Looks good to me, can you ask @hibrenda or someone from skill team to have a try? |
I tried this for todo skill. 2 findings.
|
@hibrenda @boydc2014 I have fix the first commit. For the second, I think we can have more discusses about this. |
Verified the the fix. now the resizing only for the utterance number bigger than the ratio defined |
thank you @hibrenda |
* add bootstrap sampling before publish * add reservoir sample if the utterances' number > 15000 * update the sample logic * add unit test for sampler * add downsampling config to bot * update the type * fix unit test * don't do sample for the ratio is ok Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Description
If the number of intent's utterances more than 10(can be customized) times the least number of the intent's utterances, do a re-sampling process to keep the proportion;
If detect > 15000 utterances, downsize the utterances.
add down sampling config to bot setting
![image](https://user-images.githubusercontent.com/39758135/79558327-88851080-80d6-11ea-9e03-0df6591ed0df.png)
Task Item
refs #2610
Screenshots