Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Auto-Suggestion for fields and values for structure LG #2681

Merged
merged 7 commits into from
Apr 18, 2020
Merged

fix: Auto-Suggestion for fields and values for structure LG #2681

merged 7 commits into from
Apr 18, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Apr 16, 2020 •
edited
Loading

closes #2680

Now when user entering structure LG. The editor is able to suggest all possible fields and a value for each field. The effect can be

Full LG mode:
full lg card
full lg suggest

Inline LG mode:
inline lg attachment
inline lg card

@cosmicshuai
Copy link
Contributor Author

@cwhitten
I did some modification on your original proposal.
If the editor do the suggestion for fields and values at one time, due to all the content can only be shown on a single line (newline character has no effect in suggestion window), users will see a messy suggestion.
So I changed the suggestions into seperated fileds way. Each filed and its correspongding value will become one suggestion item. And all the fields already existed in current card won't show up.
After the last field is finished. The editor will do the trimming automatically.

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.004%) to 41.945% when pulling 37b6ded on shuwan/addSuggestCardFields into 9bf98c7 on master.

@cwhitten
Copy link
Member

ok @cosmicshuai - is this still a draft or ready for review?

@cosmicshuai cosmicshuai marked this pull request as ready for review April 16, 2020 14:10
@cosmicshuai
Copy link
Contributor Author

ok @cosmicshuai - is this still a draft or ready for review?

It's ready for review.

@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Apr 16, 2020
@a-b-r-o-w-n
Copy link
Contributor

This was likely not introduced in this change, but I am seeing the suggestions being clipped:

image

@cwhitten
Copy link
Member

@a-b-r-o-w-n is the visual editor container doing the clipping?

@a-b-r-o-w-n
Copy link
Contributor

@cwhitten possibly. I thought it was the form, but didn't see any element with overflow: hidden. I didn't check the visual editor though.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Apr 17, 2020
@cosmicshuai cosmicshuai merged commit 3558910 into master Apr 18, 2020
@cosmicshuai cosmicshuai deleted the shuwan/addSuggestCardFields branch April 18, 2020 04:14
@hibrenda hibrenda mentioned this pull request Apr 20, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@cosmicshuai @a-b-r-o-w-n
fix: Auto-Suggestion for fields and values for structure LG (microsof…
126d8f3 
…t#2681)

* init

* improvement

* change suggestion item kind

* add fixedOverflowWidgets to base editor options

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmicshuai @cwhitten @a-b-r-o-w-n