Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: add keyboard shortcut for copy, cut, paste #2694

Merged
merged 9 commits into from
Apr 28, 2020

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Apr 17, 2020

Description

Add keyboard shortcut for copy, cut, paste

Task Item

fix #2082

Screenshots

copypaste

yeze322
yeze322 previously approved these changes Apr 17, 2020
Copy link
Contributor

@yeze322 yeze322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small optimization. @alanlong9278 could you attach a gif?

@yeze322 yeze322 changed the title ally: add keyboard shortcut for copy, cut, paste a11y: add keyboard shortcut for copy, cut, paste Apr 17, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 40.942% when pulling 222781d on julong/keyboardShortCut into 723785b on master.

@corinagum corinagum removed their assignment Apr 17, 2020
@cwhitten
Copy link
Member

@alanlong9278 I think this is good, however there are some pretty gnarly conflicts to fix-up as this PR is becoming stale. Can you please address conflicts?

cwhitten
cwhitten previously approved these changes Apr 27, 2020
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once conflicts are addressed.

@alanlong9278
Copy link
Contributor Author

alanlong9278 commented Apr 28, 2020

Approved once conflicts are addressed.

@cwhitten Fixed the conflicts and the announce will be added in #2756 if this pr is merged before it. Could you approve it again?

@cwhitten cwhitten merged commit 81367b1 into master Apr 28, 2020
@cwhitten cwhitten deleted the julong/keyboardShortCut branch April 28, 2020 15:50
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* open node shortcut for visual editor

* refactor

* move focus to nexe node

* delete useless code

* fix some bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants