Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some UI bugs #2714

Merged
merged 2 commits into from
Apr 20, 2020
Merged

fix: some UI bugs #2714

merged 2 commits into from
Apr 20, 2020

Conversation

liweitian
Copy link
Contributor

Description

  1. update css code during 'focus state' to make code style unified.
  2. only show element's border when it is focused by keyboard(tab or arrow keys) rather than 'mouse click'

Task Item

Screenshots

aaaaa

@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Apr 20, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Apr 20, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit 8c3878a into microsoft:master Apr 20, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling ea2fa39 on liweitian:UIBug into 52548b8 on microsoft:master.

@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@liweitian @a-b-r-o-w-n
style: unify focus style (microsoft#2714)
4e69512 
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liweitian @a-b-r-o-w-n