Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable mockremote plugin #2766

Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix: disable mockremote plugin #2766

merged 1 commit into from
Apr 24, 2020

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Apr 24, 2020 •
edited by a-b-r-o-w-n
Loading

mockremote plugin should not be enabled in master, it has no build script, will break if you haven't built it once.

refs #2766

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling d9645c3 on donglei/disable-plugin into 2c4fe20 on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit f42ea20 into master Apr 24, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the donglei/disable-plugin branch April 24, 2020 17:02
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@boydc2014
chore: disable mockRemotePublish plugin (microsoft#2766)
5fda61d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbrown benbrown benbrown approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boydc2014 @benbrown @a-b-r-o-w-n