Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the action in new dialog should be an Array #2776

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Apr 26, 2020

Description

The actions need to be set as an array

Task Item

refs #2775

Screenshots

@yeze322
Copy link
Contributor

yeze322 commented Apr 26, 2020

createDialog additional context:

  1. createDialog started to receive the action seed after we shipped the 'Move' feature.
  2. Semantically, I think createDialog requires a dialog seed (instead of action seed), so it would be easy to make a mistake passing {} to the handler.
  3. About 'actions' field in a dialog:
    • If the actions field of a dialog is unset, action API can generate correct data;
    • however, when the actions set to {} which is unexpected, the result will be wrong.

Actions I want to take in another PR:

  • let toolbar consume the createDialog handler in useDialogApi hook as a followup of the 'unified CRUD lib' item

@cwhitten
Copy link
Member

Thank you @lei9444 - this was my mistake! Better typings would have caught this.

@cwhitten cwhitten merged commit 77d9578 into microsoft:master Apr 26, 2020
@lei9444 lei9444 deleted the fixnew branch May 9, 2020 00:38
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants