Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only apply throttle on lu/lg update handler #2823

Merged
merged 5 commits into from
Apr 30, 2020
Merged

fix: only apply throttle on lu/lg update handler #2823

merged 5 commits into from
Apr 30, 2020
+131 −118

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Apr 29, 2020 •
edited
Loading

Description

close #2823
follows #2632

Apply throttle only to updateLgTemplate and updateLuIntent to resolve concurrency issue.

(Many lines changed just because of the linr indent change)

Task Item

Screenshots

@yeze322
Copy link
Contributor Author

yeze322 commented Apr 29, 2020

@lei9444

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 57b3490 on zeye/lulgthrottle into 843d639 on master.

@lei9444
Copy link
Contributor

lei9444 commented Apr 29, 2020

@lei9444

Verified with #2742 and the bug is fixed

@lei9444 lei9444 mentioned this pull request Apr 30, 2020
Merged
@yeze322 yeze322 marked this pull request as ready for review April 30, 2020 03:17
a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Apr 30, 2020
View reviewed changes
@a-b-r-o-w-n a-b-r-o-w-n merged commit 4767c24 into master Apr 30, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the zeye/lulgthrottle branch April 30, 2020 19:26
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @a-b-r-o-w-n
fix: only apply throttle on lu/lg update handler (microsoft#2823)
215c93b 
* only apply throttle on lu/lg `update` handler

* fix ts type validation

* apply addLgTemplate

Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeze322 @lei9444 @cwhitten @a-b-r-o-w-n