fix: clean LG/LU resources when deleting a Trigger #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten and
srinaath
as code owners
cwhitten
approved these changes
Apr 30, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* pass shellApi as a params into hook * clean trigger resources by using useTriggerApi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #2209
When deleting a trigger, let the handler invoke resource api to perform a cleanup.
Considering DesignPage is not under
<Extension>context, I made some hooks receiveshellApiinstead of having a dependency onuseShellApiTask Item
Screenshots