fix: prevent infinite render loop #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
vishwacsena
previously approved these changes
May 3, 2020
There was a problem hiding this comment.
Verified functionally unblocks the freeze for both ConfirmInput as well as HttpAction.
@cwhitten can we get an electron app with this fix? Private is ok - just for the demo video.
boydc2014
previously approved these changes
May 3, 2020
boydc2014
approved these changes
May 3, 2020
|
fixed UT and merged it. cc @cwhitten |
7 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* remove role field override when getting ui options * fix UT Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where opening HTTPRequest or ConfirmInput results in a browser crash.
Task Item
fixes #2867