Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Action Flow gradual left alignment #2909

Merged
merged 5 commits into from
May 6, 2020
Merged

fix: Action Flow gradual left alignment #2909

merged 5 commits into from
May 6, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented May 6, 2020 •
edited
Loading

Description

fixes #2879

Implement 'gradual left alignment' by enhancing the bound calculation of Action Flow elements.

How to implement 'gradual left alignment'?

  1. Editor remains center aligned
  2. Limit flow canvas max-width to editor width (max-width: 100%) and
    • If flow real width <= editor.width, flow.width = real width, looks like center aligned
    • If flow real width > editor.width, flow.width = editor.width, looks like left aligned

Layout Changes

  1. Boundary of entire Action Flow
    image

  2. Boundary of branching actions - IfCondition, SwitchCondition
    image

Demo

grad-flow-size

Task Item

Screenshots

@github-actions
Copy link

github-actions bot commented May 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 40e14e6 on visual/grad-align into 70b9715 on master.

@yeze322 yeze322 marked this pull request as ready for review May 6, 2020 08:05
@yeze322 yeze322 mentioned this pull request May 6, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this May 6, 2020
@cwhitten cwhitten merged commit e65569b into master May 6, 2020
@cwhitten cwhitten deleted the visual/grad-align branch May 6, 2020 17:49
alanlong9278 added a commit that referenced this pull request May 7, 2020
@alanlong9278
Merge branch 'master' into julong/focusMove
c451040 
* master: (58 commits)
  fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932)
  feat: Goto Begin Dialog after clicking dialog (#2922)
  fix: Improved Electron auto update UX (#2925)
  fix: Action Flow gradual left alignment (#2909)
  fix: word wrap in SendActivity (#2908)
  fix: Fixed various onboarding issues and updated content (#2900)
  chore: Component Governance (#2899)
  perf: improve property editor performance (#2921)
  fix: paste blank node (#2905)
  extract memory variables at lg lsp server (#2902)
  feat: manage samples via plugin (#2805)
  can not use event capture in visual editor (#2913)
  style: make focus styles more consistent (#2898)
  feat: azure publish plugin (#2733)
  fix: unable to clear form title (#2885)
  fix: Populate env variable with AppData folder (#2894)
  a11y: use Key/Value aria labels in object field (#2890)
  Fix border issue in visual editor (#2891)
  fix: changes manifest type from '.manifest' to '.json' (#2888)
  Fixed packaged folder structure. (#2887)
  ...
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @cwhitten
fix: Action Flow gradual left alignment (microsoft#2909)
010c90a 
* gradual left alignment of StepFlow

* put shared branch sizes to ElementSizes

* more accurate branching layout width calculation

* fix UT

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeze322 @a-b-r-o-w-n @cwhitten