a11y: add ARIA landmarks for navigation regions #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/BotFramework-Composer into beyackle/addAriaRegions
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
approved these changes
May 7, 2020
a-b-r-o-w-n
added a commit
that referenced
this pull request
May 8, 2020
This reverts commit e646d6f.
cwhitten
pushed a commit
that referenced
this pull request
May 8, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* regions in LG page * add more regions * Update index.tsx * Update index.tsx * add more region labels * lint * update ergion names * Update index.tsx * Update index.tsx * Update index.tsx
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…)" (microsoft#2957) This reverts commit 0b04c5f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a bunch of named landmarks to the Composer pages so SR users have a quick way to navigate between parts of the app.
Task Item
closes #2080