Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing app-update.yml file. #3010

Merged
merged 2 commits into from
May 12, 2020
Merged

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented May 12, 2020

Description

electron-updater requires an internal app-update.yml file in order to successfully perform an update in production.

This PR addresses that by packing that file into the packaged app.

Task Item

Fixes #3006

Screenshots

Windows:

image

image

Mac:

Before:

missing-file

After:

Screen Shot 2020-05-12 at 12 58 23 PM

Downloading:

downloading

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 7a0e9f2 on toanzian/update-yml into 37dd3dd on master.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 648dbd4 into master May 12, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the toanzian/update-yml branch May 12, 2020 20:18
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants