Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to open another bot #3051

Merged
merged 3 commits into from
May 14, 2020
Merged

fix: Unable to open another bot #3051

merged 3 commits into from
May 14, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented May 14, 2020 •
edited
Loading

Description

Open a new bot:

  1. call a http request, and server return the opened project.
  2. dispatch the project data to store
  3. navigate to design page
  4. dispatch location to store
  5. navigate to begin dialog

we should use location in store to check side effect, because the reach/router history may change faster than store.

the reason is when navigate to the begin dialog after open a new bot, the url is generated from unchanged design location.

I will refactor the router location in (refs #3022) to

  • one way data-flow

  • make store as one unique source

  • refactor the navigation action (use dispatch and update history to store)

Task Item

fixes #3028

Screenshots

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 6ad9e7f on lei9444:navigation into 7c59824 on microsoft:master.

@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label May 14, 2020
@cwhitten cwhitten merged commit 488e8d2 into microsoft:master May 14, 2020
@cwhitten cwhitten mentioned this pull request May 14, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
@lei9444 lei9444 deleted the navigation branch May 21, 2020 07:04
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444 @a-b-r-o-w-n @cwhitten
fix: Unable to open another bot (microsoft#3051)
0a807a0 
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lei9444 @coveralls @a-b-r-o-w-n @cwhitten