fix: remove cache when getProjectById #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
May 15, 2020
boydc2014
changed the title
a-b-r-o-w-n
approved these changes
May 15, 2020
cwhitten
approved these changes
May 15, 2020
7 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* do not use cache at getProjectById * change skill manifest to warning * code style Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove use cache at getProjectById introduced by #2786 to prevent high frequency server index.
nowadays, benefit from LeiLei's work, client do not fetch project at every route change, so there is no need to use cache at
getProjectByIdanymore.When use want a fresh from server,
ctrl-frefresh page would work as expected.Appends:
Also fixed a skill validating ui.
Task Item
close #3068
Screenshots
skill url validating spinner
