feat: Added custom windows / mac installer graphics. #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
reviewed
May 15, 2020
| @@ -56,6 +57,8 @@ | |||
| "runAfterFinish": true, | |||
| "installerIcon": "resources/composerIcon.ico", | |||
| "uninstallerIcon": "resources/composerIcon.ico", | |||
There was a problem hiding this comment.
can we remove resources/ now since we used it above as a directory?
There was a problem hiding this comment.
good catch! I think we can
|
This looks neat!! |
|
I have never been part of a product launch that had an installer that looks as nice as this one!! |
…oft/BotFramework-Composer into toanzian/installer-assets
…mposer into toanzian/installer-assets
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum and
cwhitten
as code owners
cwhitten
approved these changes
May 15, 2020
|
whohoo! |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added custom windows installer graphics. * Added custom mac installer graphics. * Removed redundant build resource file paths. Co-authored-by: Tony Anziano <tonyanziano@Tonys-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds custom images to the Windows and Mac (.dmg) installers.
Task Item
Fixes #3083
Screenshots
Before - Windows
After - Windows
Before - Mac
After - Mac