refactor: clean up the 'slot' abstraction for abs-h #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
boydc2014
reviewed
May 27, 2020
| @@ -4,7 +4,7 @@ | |||
| export const OBFUSCATED_VALUE = '*****'; | |||
|
|
|||
| export interface ISettingManager { | |||
| get(slot?: string, obfuscate?: boolean): Promise<any | null>; | |||
| set(slot: string, settings: any): Promise<void>; | |||
| get(obfuscate?: boolean): Promise<any | null>; | |||
There was a problem hiding this comment.
Should we also take the chance of remove this obfuscate feature, @cwhitten what do you think? I think we chatted about this
There was a problem hiding this comment.
Let's leave it in for now ad revisit once some customers have successfully deployed Composer and we get some additional feedback.
boydc2014
approved these changes
May 27, 2020
boydc2014
changed the title
boydc2014
changed the title
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* clean setting slot related code * remove abshost flag Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clean the code
Task Item
#minor
Screenshots